Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool-Docker-action to v2.1.0 #880

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

nwiltsie
Copy link
Member

This PR updates the tool-Docker-action Action to version 2.1.0. There are a few big changes in this version:

  1. Pushing to any branch foo will build this repository's image and tag it as branch-foo. That tagged image will be removed when the branch is deleted.
  2. By default the Action will only build SemVer tags (e.g. v1.2.3-xxx). Repositories that need to use other kinds of tags (e.g. v1.2beta) can pass the optional non-semver-tags argument; doing so will build all tags that begin with v.

There are a bunch of smaller changes buried in there - you can see them all at this link.

Based on this repository's existing tags, I've determined that it does follow semantic versioning. The updated workflow therefore does not pass the non-semver-tags argument to the Action, although it can be uncommented in the future if need be.

@nwiltsie nwiltsie requested a review from zhuchcn August 16, 2024 16:56
Copy link
Member

@zhuchcn zhuchcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep workflow_dispatch? Also, is github-token no longer needed?

.github/workflows/docker-build-release.yaml Show resolved Hide resolved
@nwiltsie
Copy link
Member Author

Can we keep workflow_dispatch?

Shoot, I added back in the unstable tagging logic but forgot to add workflow_dispatch. I'll fix that up.

Also, is github-token no longer needed?

There is still a github-token argument, but it defaults to ${{ github.token }} so we generally don't need to provide it explicitly.

@nwiltsie
Copy link
Member Author

Okay, I've added workflow_dispatch back in with 8e7a994.

@nwiltsie nwiltsie requested a review from zhuchcn August 16, 2024 21:33
Copy link
Member

@zhuchcn zhuchcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you!

@nwiltsie nwiltsie merged commit c1bc3a2 into main Aug 16, 2024
7 checks passed
@nwiltsie nwiltsie deleted the nwiltsie_update_docker_action branch August 16, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants